Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Star tree mapping changes #14655

Closed
wants to merge 1 commit into from
Closed

[Backport 2.x] Star tree mapping changes #14655

wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 6267e94 from #14605.

@github-actions
Star tree mapping changes (#14605)
9ad161c 
* Star tree mapping changes with feature flag
---------
Signed-off-by: Bharathwaj G <[email protected]>
(cherry picked from commit 6267e94)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

❕ Gradle check result for 9ad161c: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Jul 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.39062% with 126 lines in your changes missing coverage. Please review.

Project coverage is 71.59%. Comparing base (3a1be63) to head (9ad161c).
Report is 169 commits behind head on 2.x.

Files Patch % Lines
...va/org/opensearch/index/mapper/StarTreeMapper.java 81.81% 20 Missing and 8 partials ⚠️
...java/org/opensearch/index/mapper/ObjectMapper.java 56.60% 14 Missing and 9 partials ⚠️
...siteindex/datacube/startree/StarTreeValidator.java 65.78% 9 Missing and 4 partials ⚠️
...ndex/compositeindex/datacube/DimensionFactory.java 58.62% 8 Missing and 4 partials ⚠️
.../datacube/startree/StarTreeFieldConfiguration.java 72.72% 6 Missing and 3 partials ⚠️
...ompositeindex/datacube/startree/StarTreeField.java 80.00% 2 Missing and 5 partials ⚠️
...nsearch/index/mapper/CompositeMappedFieldType.java 64.70% 6 Missing ⚠️
...h/index/compositeindex/CompositeIndexSettings.java 58.33% 4 Missing and 1 partial ⚠️
.../index/compositeindex/CompositeIndexValidator.java 50.00% 3 Missing and 1 partial ⚠️
...ensearch/index/compositeindex/datacube/Metric.java 80.00% 1 Missing and 3 partials ⚠️
... and 8 more
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #14655      +/-   ##
============================================
+ Coverage     71.50%   71.59%   +0.09%     
- Complexity    62406    62523     +117     
============================================
  Files          5103     5117      +14     
  Lines        293265   293774     +509     
  Branches      42730    42812      +82     
============================================
+ Hits         209689   210341     +652     
+ Misses        65946    65744     -202     
- Partials      17630    17689      +59

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock
Copy link
Member

dblock commented Jul 23, 2024

@bharath-techie this was not merged, it will need a manual backport please

@dblock dblock mentioned this pull request Jul 23, 2024
Merged
3 tasks
@prudhvigodithi prudhvigodithi mentioned this pull request Jul 23, 2024
Closed
74 tasks
@dblock dblock added the v2.16.0 Issues and PRs related to version 2.16.0 label Jul 23, 2024
@dblock
Copy link
Member

dblock commented Jul 23, 2024

@sachinpkale

@sarthakaggarwal97
Copy link
Contributor

@dblock I think this is not getting backported to this 2.16, and will be tagged with 2.17
I will let @bharath-techie and @sachinpkale confirm once tho

@dblock
Copy link
Member

dblock commented Jul 24, 2024

This has not been backported to any 2.x though. If it's 2.17 it can be backported now.

@bharath-techie
Copy link
Contributor

This has not been backported to any 2.x though. If it's 2.17 it can be backported now.

Hey yes this will be part of 2.17.

@dblock
Copy link
Member

dblock commented Jul 24, 2024

This has not been backported to any 2.x though. If it's 2.17 it can be backported now.

Hey yes this will be part of 2.17.

Cool. You should rebase this PR now and we can merge it to 2.x.

@getsaurabh02 getsaurabh02 added v2.17.0 and removed v2.16.0 Issues and PRs related to version 2.16.0 labels Jul 25, 2024
@getsaurabh02
Copy link
Member

Updating the PR label to 2.17. Please continue wit the 2.x backport

@bharath-techie
Copy link
Contributor

This is already merged, so closing

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
v2.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dblock @sarthakaggarwal97 @bharath-techie @getsaurabh02